From 1b03dfed182a1dc47cc0eb1047a34cd914440ce6 Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Sat, 29 Jul 2006 02:10:07 +0200 Subject: [PATCH] Fix http-fetch With the latest changes in fetch.c, http-fetch crashed accessing write_ref[i], where write_ref was NULL. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano --- fetch.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fetch.c b/fetch.c index 2151c7b78c..aeb6bf2639 100644 --- a/fetch.c +++ b/fetch.c @@ -245,7 +245,7 @@ void pull_targets_free(int targets, char **target, const char **write_ref) { while (targets--) { free(target[targets]); - if (write_ref[targets]) + if (write_ref && write_ref[targets]) free((char *) write_ref[targets]); } } @@ -263,7 +263,7 @@ int pull(int targets, char **target, const char **write_ref, track_object_refs = 0; for (i = 0; i < targets; i++) { - if (!write_ref[i]) + if (!write_ref || !write_ref[i]) continue; lock[i] = lock_ref_sha1(write_ref[i], NULL, 0); @@ -295,7 +295,7 @@ int pull(int targets, char **target, const char **write_ref, msg = NULL; } for (i = 0; i < targets; i++) { - if (!write_ref[i]) + if (!write_ref || !write_ref[i]) continue; ret = write_ref_sha1(lock[i], &sha1[20 * i], msg ? msg : "fetch (unknown)"); lock[i] = NULL; -- 2.11.4.GIT