| commit | d33738d7d3ed42a956c74d0125eb2b3abda451b7 | |
| author | Jonathan Nieder <jrnieder@gmail.com> | |
| Wed, 11 Nov 2009 23:56:07 +0000 (11 17:56 -0600) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 13 Nov 2009 20:15:28 +0000 (13 12:15 -0800) | ||
| tree | 414fdfcc1767201d02b06169857ba3db182ccebf | treesnapshot (tar.gz zip) |
| parent | eab58f1e8e5ef86b5075ce6dfcd6d3f1b3b888b3 | commitdiff |
Do not use VISUAL editor on dumb terminals
Refuse to use $VISUAL and fall back to $EDITOR if TERM is unset
or set to "dumb". Traditionally, VISUAL is set to a screen
editor and EDITOR to a line-based editor, which should be more
useful in that situation.
vim, for example, is happy to assume a terminal supports ANSI
sequences even if TERM is dumb (e.g., when running from a text
editor like Acme). git already refuses to fall back to vi on a
dumb terminal if GIT_EDITOR, core.editor, VISUAL, and EDITOR are
unset, but without this patch, that check is suppressed by
VISUAL=vi.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Refuse to use $VISUAL and fall back to $EDITOR if TERM is unset
or set to "dumb". Traditionally, VISUAL is set to a screen
editor and EDITOR to a line-based editor, which should be more
useful in that situation.
vim, for example, is happy to assume a terminal supports ANSI
sequences even if TERM is dumb (e.g., when running from a text
editor like Acme). git already refuses to fall back to vi on a
dumb terminal if GIT_EDITOR, core.editor, VISUAL, and EDITOR are
unset, but without this patch, that check is suppressed by
VISUAL=vi.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| editor.c | diffblobblamehistory | |
| t/t7005-editor.sh | diffblobblamehistory | |
| t/t7501-commit.sh | diffblobblamehistory | |
| t/test-lib.sh | diffblobblamehistory |