| commit | 7f8508e8d320d768a34483682e9f2dc5af1af04b | |
| author | Linus Torvalds <torvalds@osdl.org> | |
| Mon, 31 Jul 2006 16:55:15 +0000 (31 09:55 -0700) | ||
| committer | Junio C Hamano <junkio@cox.net> | |
| Mon, 31 Jul 2006 18:55:56 +0000 (31 11:55 -0700) | ||
| tree | 40434a406220ddd64980cc6f23ea5a6d8f4c2c7c | treesnapshot (tar.gz zip) |
| parent | b63fafdfd844c2037fba53b9944431c1378b4135 | commitdiff |
Fix double "close()" in ce_compare_data
Doing an "strace" on "git diff" shows that we close() a file descriptor
twice (getting EBADFD on the second one) when we end up in ce_compare_data
if the index does not match the checked-out stat information.
The "index_fd()" function will already have closed the fd for us, so we
should not close it again.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Doing an "strace" on "git diff" shows that we close() a file descriptor
twice (getting EBADFD on the second one) when we end up in ce_compare_data
if the index does not match the checked-out stat information.
The "index_fd()" function will already have closed the fd for us, so we
should not close it again.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
| read-cache.c | diffblobblamehistory |