shortlog: fix segfault on empty authorname
[git/dscho.git] / run-command.c
blob61908682b9b251ac49ae655522a3143476a888ea
1 #include "cache.h"
2 #include "run-command.h"
3 #include <sys/wait.h>
4 #include "exec_cmd.h"
6 int run_command_v_opt(int argc, const char **argv, int flags)
8 pid_t pid = fork();
10 if (pid < 0)
11 return -ERR_RUN_COMMAND_FORK;
12 if (!pid) {
13 if (flags & RUN_COMMAND_NO_STDIO) {
14 int fd = open("/dev/null", O_RDWR);
15 dup2(fd, 0);
16 dup2(fd, 1);
17 close(fd);
19 if (flags & RUN_GIT_CMD) {
20 execv_git_cmd(argv);
21 } else {
22 execvp(argv[0], (char *const*) argv);
24 die("exec %s failed.", argv[0]);
26 for (;;) {
27 int status, code;
28 pid_t waiting = waitpid(pid, &status, 0);
30 if (waiting < 0) {
31 if (errno == EINTR)
32 continue;
33 error("waitpid failed (%s)", strerror(errno));
34 return -ERR_RUN_COMMAND_WAITPID;
36 if (waiting != pid)
37 return -ERR_RUN_COMMAND_WAITPID_WRONG_PID;
38 if (WIFSIGNALED(status))
39 return -ERR_RUN_COMMAND_WAITPID_SIGNAL;
41 if (!WIFEXITED(status))
42 return -ERR_RUN_COMMAND_WAITPID_NOEXIT;
43 code = WEXITSTATUS(status);
44 if (code)
45 return -code;
46 return 0;
50 int run_command_v(int argc, const char **argv)
52 return run_command_v_opt(argc, argv, 0);
55 int run_command(const char *cmd, ...)
57 int argc;
58 const char *argv[MAX_RUN_COMMAND_ARGS];
59 const char *arg;
60 va_list param;
62 va_start(param, cmd);
63 argv[0] = (char*) cmd;
64 argc = 1;
65 while (argc < MAX_RUN_COMMAND_ARGS) {
66 arg = argv[argc++] = va_arg(param, char *);
67 if (!arg)
68 break;
70 va_end(param);
71 if (MAX_RUN_COMMAND_ARGS <= argc)
72 return error("too many args to run %s", cmd);
73 return run_command_v_opt(argc, argv, 0);