From 35166b1fb54d6c3ca0d9150fd766598a2d3d17b2 Mon Sep 17 00:00:00 2001 From: Denton Liu Date: Wed, 7 Oct 2020 00:56:18 -0700 Subject: [PATCH] t2016: add a NEEDSWORK about the PERL prerequisite Since the builtin add-p is used when $GIT_TEST_ADD_I_USE_BUILTIN is given, we should replace the PERL prerequisite with an ADD_I prerequisite which first checks if $GIT_TEST_ADD_I_USE_BUILTIN is defined before checking PERL.[0] Mark this in a NEEDSWORK so that it can be addressed at a later time. [0]: https://lore.kernel.org/git/xmqqsgat7ttf.fsf@gitster.c.googlers.com/ Signed-off-by: Denton Liu Signed-off-by: Junio C Hamano --- t/t2016-checkout-patch.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/t/t2016-checkout-patch.sh b/t/t2016-checkout-patch.sh index 999620e507..d91a329eb3 100755 --- a/t/t2016-checkout-patch.sh +++ b/t/t2016-checkout-patch.sh @@ -18,6 +18,10 @@ test_expect_success PERL 'setup' ' # note: bar sorts before dir/foo, so the first 'n' is always to skip 'bar' +# NEEDSWORK: Since the builtin add-p is used when $GIT_TEST_ADD_I_USE_BUILTIN +# is given, we should replace the PERL prerequisite with an ADD_I prerequisite +# which first checks if $GIT_TEST_ADD_I_USE_BUILTIN is defined before checking +# PERL. test_expect_success PERL 'saying "n" does nothing' ' set_and_save_state dir/foo work head && test_write_lines n n | git checkout -p && -- 2.11.4.GIT