| commit | fa06eb6fa906f0b6e44046fe7b077d71ebb4d6e4 | |
| author | SZEDER Gábor <szeder.dev@gmail.com> | |
| Fri, 23 Feb 2018 23:39:45 +0000 (24 00:39 +0100) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 28 Feb 2018 20:57:51 +0000 (28 12:57 -0800) | ||
| tree | 4361a0e67efe23ce898a5be5128ad608b6352946 | treesnapshot (tar.gz zip) |
| parent | 40dc533f5776aa0fe194176032f7eb38ee5f44b7 | commitdiff |
t5500-fetch-pack: don't check the stderr of a subshell
Three "missing reference" tests in 't5500-fetch-pack.sh' fail when the
test script is run with '-x' tracing (and using a shell other than a
Bash version supporting BASH_XTRACEFD). The reason for those failures
is that the tests check a subshell's stderr, which includes the trace
of executing commands in that subshell as well, throwing off the
comparison with the expected output.
Save the stderr of 'git fetch-pack' only instead of the whole
subshell, so it remains free from tracing output.
After this change t5500 passes with '-x', even when running with
/bin/sh.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Three "missing reference" tests in 't5500-fetch-pack.sh' fail when the
test script is run with '-x' tracing (and using a shell other than a
Bash version supporting BASH_XTRACEFD). The reason for those failures
is that the tests check a subshell's stderr, which includes the trace
of executing commands in that subshell as well, throwing off the
comparison with the expected output.
Save the stderr of 'git fetch-pack' only instead of the whole
subshell, so it remains free from tracing output.
After this change t5500 passes with '-x', even when running with
/bin/sh.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| t/t5500-fetch-pack.sh | diffblobblamehistory |