ls-remote & transport API: release "struct transport_ls_refs_options"
commitf36d4f8316ac567bd3bd0de3c051f2cd8ae2444b
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Sat, 5 Feb 2022 00:08:14 +0000 (5 01:08 +0100)
committerJunio C Hamano <gitster@pobox.com>
Mon, 7 Feb 2022 02:02:34 +0000 (6 18:02 -0800)
tree0ac9ac390046bb4ce4158e89483cfd4ff1e69cbf
parent38062e73e009f27ea192d50481fcb5e7b0e9d6eb
ls-remote & transport API: release "struct transport_ls_refs_options"

Fix a memory leak in codepaths that use the "struct
transport_ls_refs_options" API. Since the introduction of the struct
in 39835409d10 (connect, transport: encapsulate arg in struct,
2021-02-05) the caller has been responsible for freeing it.

That commit in turn migrated code originally added in
402c47d9391 (clone: send ref-prefixes when using protocol v2,
2018-07-20) and b4be74105fe (ls-remote: pass ref prefixes when
requesting a remote's refs, 2018-03-15). Only some of those codepaths
were releasing the allocated resources of the struct, now all of them
will.

Mark the "t/t5511-refspec.sh" test as passing when git is compiled
with SANITIZE=leak. They'll now be listed as running under the
"GIT_TEST_PASSING_SANITIZE_LEAK=true" test mode (the "linux-leaks" CI
target). Previously 24/47 tests would fail.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/clone.c
builtin/fetch.c
builtin/ls-remote.c
connect.c
t/t5511-refspec.sh
transport.c
transport.h