| commit | eff40457a4ab4887c677453d11774322a494a98c | |
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | |
| Thu, 8 Jul 2021 10:53:15 +0000 (8 12:53 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Thu, 8 Jul 2021 15:20:16 +0000 (8 08:20 -0700) | ||
| tree | 0000930674a61658209b20b9ff34a8a2649dc213 | treesnapshot (tar.gz zip) |
| parent | 60fadf8bd2abe6bede48bcf42377f6c8b7c1d0bb | commitdiff |
fetch: fix segfault in --negotiate-only without --negotiation-tip=*
The recent --negotiate-only option would segfault in the call to
oid_array_for_each() in negotiate_using_fetch() unless one or more
--negotiation-tip=* options were provided.
All of the other tests for the feature combine both, but nothing was
checking this assumption, let's do that and add a test for it. Fixes a
bug in 9c1e657a8fd (fetch: teach independent negotiation (no
packfile), 2021-05-04).
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The recent --negotiate-only option would segfault in the call to
oid_array_for_each() in negotiate_using_fetch() unless one or more
--negotiation-tip=* options were provided.
All of the other tests for the feature combine both, but nothing was
checking this assumption, let's do that and add a test for it. Fixes a
bug in 9c1e657a8fd (fetch: teach independent negotiation (no
packfile), 2021-05-04).
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/fetch.c | diffblobblamehistory | |
| t/t5702-protocol-v2.sh | diffblobblamehistory |