unpack-file: fix ancient leak in create_temp_file()
commite84a26e32faba0c2ae7a19fa9bf805645f620e82
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Tue, 8 Nov 2022 18:17:43 +0000 (8 19:17 +0100)
committerJunio C Hamano <gitster@pobox.com>
Mon, 21 Nov 2022 03:32:48 +0000 (21 12:32 +0900)
tree239a450569386ca23cb3480d06d0e91b1562aedf
parentb6046abc0c27134d52c56699a88d1fadfe7e66ce
unpack-file: fix ancient leak in create_temp_file()

Fix a leak that's been with us since 3407bb4940c (Add "unpack-file"
helper that unpacks a sha1 blob into a tmpfile., 2005-04-18). See
00c8fd493af (cat-file: use streaming API to print blobs, 2012-03-07)
for prior art which shows the same API pattern, i.e. free()-ing the
result of read_object_file() after it's used.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
builtin/unpack-file.c
t/t6060-merge-index.sh
t/t6401-merge-criss-cross.sh
t/t6406-merge-attr.sh
t/t6407-merge-binary.sh
t/t7605-merge-resolve.sh