| commit | d4e241a14510934420aa67c5480361376446e117 | |
| author | Jeff King <peff@peff.net> | |
| Fri, 6 Jan 2023 08:48:23 +0000 (6 03:48 -0500) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 6 Jan 2023 12:34:49 +0000 (6 21:34 +0900) | ||
| tree | 21be53fb0d969b7dd41ab94656da905879ee64be | treesnapshot (tar.gz zip) |
| parent | 876094ac16870727207e6afc0b26060101a52359 | commitdiff |
test-bundle-uri: drop unused variables
Commit 70b9c10373 (bundle-uri client: add helper for testing server,
2022-12-22) added a cmd_ls_remote() function which contains "uploadpack"
and "server_options" variables. Neither of these variables is ever
modified after being initialized, so the code to handle non-NULL and
non-empty values is impossible to reach.
While in theory we might add command-line parsing to set these, let's
drop the dead code for now in the name of cleanliness. It's easy enough
to add it back later if need be.
Noticed by Coverity.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commit 70b9c10373 (bundle-uri client: add helper for testing server,
2022-12-22) added a cmd_ls_remote() function which contains "uploadpack"
and "server_options" variables. Neither of these variables is ever
modified after being initialized, so the code to handle non-NULL and
non-empty values is impossible to reach.
While in theory we might add command-line parsing to set these, let's
drop the dead code for now in the name of cleanliness. It's easy enough
to add it back later if need be.
Noticed by Coverity.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| t/helper/test-bundle-uri.c | diffblobblamehistory |