bisect--helper: introduce new `decide_next()` function
commitbfacfce7d94951fe5b4e70bc2431dae5506b474b
authorTanushree Tumane <tanushreetumane@gmail.com>
Mon, 17 Feb 2020 08:40:31 +0000 (17 09:40 +0100)
committerJunio C Hamano <gitster@pobox.com>
Wed, 19 Feb 2020 17:37:14 +0000 (19 09:37 -0800)
tree90e1fa47eb75c8dfc15adc633c7ae84d27b95b66
parentb8e3b2f33994de25c068021e388dbef72a2cdc4a
bisect--helper: introduce new `decide_next()` function

Let's refactor code from bisect_next_check() into a new
decide_next() helper function.

This removes some goto statements and makes the code simpler,
clearer and easier to understand.

While at it `bad_ref` and `good_glob` are not const any more
to void casting them inside `free()`.

Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/bisect--helper.c