| commit | aa59e0eaf65b1e535248f67822053e3b2f5fcc26 | |
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | |
| Fri, 9 Feb 2018 20:32:00 +0000 (9 20:32 +0000) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 9 Feb 2018 21:10:11 +0000 (9 13:10 -0800) | ||
| tree | 8c8885e040a06e5fe83aa53229382c9106ee6bd0 | treesnapshot (tar.gz zip) |
| parent | 8279ed033f703d4115bee620dccd32a9ec94d9aa | commitdiff |
fetch: don't redundantly NULL something calloc() gave us
Stop redundantly NULL-ing the last element of the refs structure,
which was retrieved via calloc(), and is thus guaranteed to be
pre-NULL'd.
This code dates back to b888d61c83 ("Make fetch a builtin",
2007-09-10), where wasn't any reason to do this back then either, it's
just boilerplate left over from when git-fetch was initially
introduced.
The motivation for this change was to make a subsequent change which
would also modify the refs variable smaller, since it won't have to
copy this redundant "NULL the last + 1 item" pattern.
We may not end up keeping that change, but as this pattern is still
pointless, so let's fix it.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Stop redundantly NULL-ing the last element of the refs structure,
which was retrieved via calloc(), and is thus guaranteed to be
pre-NULL'd.
This code dates back to b888d61c83 ("Make fetch a builtin",
2007-09-10), where wasn't any reason to do this back then either, it's
just boilerplate left over from when git-fetch was initially
introduced.
The motivation for this change was to make a subsequent change which
would also modify the refs variable smaller, since it won't have to
copy this redundant "NULL the last + 1 item" pattern.
We may not end up keeping that change, but as this pattern is still
pointless, so let's fix it.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/fetch.c | diffblobblamehistory |