| commit | 969a5645876ccf368ed74fde2c5dc9b5432b7bb0 | |
| author | Jeff King <peff@peff.net> | |
| Sun, 28 Aug 2022 12:50:50 +0000 (28 08:50 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Sun, 28 Aug 2022 20:23:37 +0000 (28 13:23 -0700) | ||
| tree | 1b9b000d98486d1a0640cc6072c14e227fe344e8 | treesnapshot (tar.gz zip) |
| parent | 761416ef91d819d84a11222ec5bc3cbc66d3ddac | commitdiff |
pack-bitmap-write: drop unused pack_idx_entry parameters
Our write_selected_commits_v1() function takes an array of
pack_idx_entry structs. We used to need them for computing commit
positions, but since aa30162559 (bitmap: move `get commit positions`
code to `bitmap_writer_finish`, 2022-08-14), the caller passes in a
separate array of positions for us. We can drop the unused array (and
its matching length parameter).
Likewise, when we added write_lookup_table() in 93eb41e240
(pack-bitmap-write.c: write lookup table extension, 2022-08-14), it
receives the same array of positions. So its "index" parameter was never
used at all.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Our write_selected_commits_v1() function takes an array of
pack_idx_entry structs. We used to need them for computing commit
positions, but since aa30162559 (bitmap: move `get commit positions`
code to `bitmap_writer_finish`, 2022-08-14), the caller passes in a
separate array of positions for us. We can drop the unused array (and
its matching length parameter).
Likewise, when we added write_lookup_table() in 93eb41e240
(pack-bitmap-write.c: write lookup table extension, 2022-08-14), it
receives the same array of positions. So its "index" parameter was never
used at all.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| pack-bitmap-write.c | diffblobblamehistory |