| commit | 80c2e9657f2d0f0cd45eec6f5e66f570bf542124 | |
| author | René Scharfe <l.s.r@web.de> | |
| Tue, 18 Jan 2022 12:45:57 +0000 (18 13:45 +0100) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 19 Jan 2022 01:11:22 +0000 (18 17:11 -0800) | ||
| tree | d270d378502070072ff363e2c074f4e543d1954f | treesnapshot (tar.gz zip) |
| parent | af4e5f569bc89f356eb34a9373d7f82aca6faa8a | commitdiff |
bisect--helper: report actual bisect_state() argument on error
The strvec "args" in bisect_run() is initialized and cleared, but never
added to. Nevertheless its first member is printed when reporting a
bisect_state() error. That's not useful, since it's always NULL.
Before d1bbbe45df (bisect--helper: reimplement `bisect_run` shell
function in C, 2021-09-13) the intended new state was reported if it
could not be set. Reinstate that behavior and remove the unused strvec.
Reported-by: Ramkumar Ramachandra <r@artagnon.com>
Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The strvec "args" in bisect_run() is initialized and cleared, but never
added to. Nevertheless its first member is printed when reporting a
bisect_state() error. That's not useful, since it's always NULL.
Before d1bbbe45df (bisect--helper: reimplement `bisect_run` shell
function in C, 2021-09-13) the intended new state was reported if it
could not be set. Reinstate that behavior and remove the unused strvec.
Reported-by: Ramkumar Ramachandra <r@artagnon.com>
Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/bisect--helper.c | diffblobblamehistory |