| commit | 7b8ce9c673324d55e2b9d8331a796c74559b04c8 | |
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | |
| Mon, 25 Mar 2019 12:08:32 +0000 (25 13:08 +0100) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 1 Apr 2019 03:14:50 +0000 (1 12:14 +0900) | ||
| tree | 6cbf0af6f63e511afe78bbf852aa31b3786b55cf | treesnapshot (tar.gz zip) |
| parent | 67a530fab3bbd1d4c3390d6f18e35ab10442c015 | commitdiff |
commit-graph verify: detect inability to read the graph
Change "commit-graph verify" to error on open() failures other than
ENOENT. As noted in the third paragraph of 283e68c72f ("commit-graph:
add 'verify' subcommand", 2018-06-27) and the test it added it's
intentional that "commit-graph verify" doesn't error out when the file
doesn't exist.
But let's not be overly promiscuous in what we accept. If we can't
read the file for other reasons, e.g. permission errors, bad file
descriptor etc. we'd like to report an error to the user.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Change "commit-graph verify" to error on open() failures other than
ENOENT. As noted in the third paragraph of 283e68c72f ("commit-graph:
add 'verify' subcommand", 2018-06-27) and the test it added it's
intentional that "commit-graph verify" doesn't error out when the file
doesn't exist.
But let's not be overly promiscuous in what we accept. If we can't
read the file for other reasons, e.g. permission errors, bad file
descriptor etc. we'd like to report an error to the user.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/commit-graph.c | diffblobblamehistory | |
| t/t5318-commit-graph.sh | diffblobblamehistory |