| commit | 6e8d46f9d4bb3643b8fdf4e1b0856f7910dbc948 | |
| author | Junio C Hamano <gitster@pobox.com> | |
| Wed, 28 Oct 2015 21:05:53 +0000 (28 14:05 -0700) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 15 Jan 2016 18:33:28 +0000 (15 10:33 -0800) | ||
| tree | 1c2054b362b04919d41b8c823c013e86d2c928fe | treesnapshot (tar.gz zip) |
| parent | c0353c78e80434b9385e134c69b54b048c382077 | commitdiff |
revision: read --stdin with strbuf_getline()
Reading with getwholeline() and manually stripping the terminating
'\n' would leave CR at the end of the line if the input comes from
a DOS editor.
Constrasting this with the other changes around "--stdin" in this
series, one may realize that the way "log" family of commands read
the paths with "--stdin" looks inconsistent and sloppy. It does not
allow us to C-quote a textual input, neither does it accept records
that are NUL-terminated. These are unfortunately way too late to
fix X-<.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Reading with getwholeline() and manually stripping the terminating
'\n' would leave CR at the end of the line if the input comes from
a DOS editor.
Constrasting this with the other changes around "--stdin" in this
series, one may realize that the way "log" family of commands read
the paths with "--stdin" looks inconsistent and sloppy. It does not
allow us to C-quote a textual input, neither does it accept records
that are NUL-terminated. These are unfortunately way too late to
fix X-<.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| revision.c | diffblobblamehistory |