mingw: avoid fallback for {local,gm}time_r()
commit6e7ad1e4c22e7038975ba37c7413374fe566b064
authorCarlo Marcelo Arenas Belón <carenas@gmail.com>
Sat, 27 Nov 2021 10:15:32 +0000 (27 10:15 +0000)
committerJohannes Schindelin <johannes.schindelin@gmx.de>
Thu, 17 Mar 2022 11:52:12 +0000 (17 12:52 +0100)
tree742bc0a88a7af3e1b85e94a264346ffb57b2e1ca
parent94f6e3e283f2adfc518b39cfc39291f1c2832ad0
mingw: avoid fallback for {local,gm}time_r()

mingw-w64's pthread_unistd.h had a bug that mistakenly (because there is
no support for the *lockfile() functions required[1]) defined
_POSIX_THREAD_SAFE_FUNCTIONS and that was being worked around since
3ecd153a3b (compat/mingw: support MSys2-based MinGW build, 2016-01-14).

The bug was fixed in winphtreads, but as a side effect, leaves the
reentrant functions from time.h no longer visible and therefore breaks
the build.

Since the intention all along was to avoid using the fallback functions,
formalize the use of POSIX by setting the corresponding feature flag and
compile out the implementation for the fallback functions.

[1] https://unix.org/whitepapers/reentrant.html

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
compat/mingw.c
git-compat-util.h