| commit | 6c37f3ec1b89f317bd379ce4db307f700ca4acd9 | |
| author | Denton Liu <liu.denton@gmail.com> | |
| Wed, 27 Nov 2019 19:53:31 +0000 (27 11:53 -0800) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 29 Nov 2019 21:20:14 +0000 (29 13:20 -0800) | ||
| tree | 2843c7ff76686493d99ee6c0464edab889ec30b0 | treesnapshot (tar.gz zip) |
| parent | b66e0a1773e941f3cd6b837346dfa98cbb8ddabb | commitdiff |
t5317: stop losing return codes of git commands
Currently, there are two ways where the return codes of git commands are
lost. The first way is when a command is in the upstream of a pipe. In a
pipe, only the return code of the last command is used. Thus, all other
commands will have their return codes masked. Rewrite pipes so that
there are no git commands upstream.
The other way is when a command is in a non-assignment command
substitution. The return code will be lost in favour of the surrounding
command's. Rewrite instances of this such that git commands output to a
file and surrounding commands only call command substitutions with
non-git commands.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Currently, there are two ways where the return codes of git commands are
lost. The first way is when a command is in the upstream of a pipe. In a
pipe, only the return code of the last command is used. Thus, all other
commands will have their return codes masked. Rewrite pipes so that
there are no git commands upstream.
The other way is when a command is in a non-assignment command
substitution. The return code will be lost in favour of the surrounding
command's. Rewrite instances of this such that git commands output to a
file and surrounding commands only call command substitutions with
non-git commands.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| t/t5317-pack-objects-filter-objects.sh | diffblobblamehistory |