| commit | 57d84f8d93a0e0818fc403c5b1a2ba73ce0eca5a | |
| author | Nguyễn Thái Ngọc Duy <pclouds@gmail.com> | |
| Mon, 6 Aug 2012 11:27:09 +0000 (6 18:27 +0700) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 6 Aug 2012 17:01:21 +0000 (6 10:01 -0700) | ||
| tree | dc69a0cce751d965655e9270969feb88cdbb28e7 | treesnapshot (tar.gz zip) |
| parent | f174a2583c9f42315b60205890fa67a79a1f1669 | commitdiff |
read_index_from: remove bogus errno assignments
These assignments comes from the very first commit e83c516 (Initial
revision of "git", the information manager from hell - 2005-04-07).
Back then we did not die() when errors happened so correct errno was
required.
Since 5d1a5c0 ([PATCH] Better error reporting for "git status" -
2005-10-01), read_index_from() learned to die rather than just return
-1 and these assignments became irrelevant. Remove them.
While at it, move die_errno() next to xmmap() call because it's the
mmap's error code that we care about. Otherwise if close(fd); fails,
it could overwrite mmap's errno.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
These assignments comes from the very first commit e83c516 (Initial
revision of "git", the information manager from hell - 2005-04-07).
Back then we did not die() when errors happened so correct errno was
required.
Since 5d1a5c0 ([PATCH] Better error reporting for "git status" -
2005-10-01), read_index_from() learned to die rather than just return
-1 and these assignments became irrelevant. Remove them.
While at it, move die_errno() next to xmmap() call because it's the
mmap's error code that we care about. Otherwise if close(fd); fails,
it could overwrite mmap's errno.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| read-cache.c | diffblobblamehistory |