| commit | 3e2feb0d64c994d343b42a62bd521fb5d6bdfe02 | |
| author | Martin Ågren <martin.agren@gmail.com> | |
| Wed, 5 Feb 2020 17:19:22 +0000 (5 18:19 +0100) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 5 Feb 2020 18:23:42 +0000 (5 10:23 -0800) | ||
| tree | 2be948118054982014f771bdc2419f26885f77b1 | treesnapshot (tar.gz zip) |
| parent | d0654dc308b0ba76dd8ed7bbb33c8d8f7aacd783 | commitdiff |
name-rev: rewrite create_or_update_name()
This code was moved straight out of name_rev(). As such, we inherited
the "goto" to jump from an if into an else-if. We also inherited the
fact that "nothing to do -- return NULL" is handled last.
Rewrite the function to first handle the "nothing to do" case. Then we
can handle the conditional allocation early before going on to populate
the struct. No need for goto-ing.
Signed-off-by: Martin Ågren <martin.agren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This code was moved straight out of name_rev(). As such, we inherited
the "goto" to jump from an if into an else-if. We also inherited the
fact that "nothing to do -- return NULL" is handled last.
Rewrite the function to first handle the "nothing to do" case. Then we
can handle the conditional allocation early before going on to populate
the struct. No need for goto-ing.
Signed-off-by: Martin Ågren <martin.agren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/name-rev.c | diffblobblamehistory |