| commit | 3d8cbbf2c35141377a86a57a862e74c270e59a2a | |
| author | René Scharfe <l.s.r@web.de> | |
| Sat, 13 Mar 2021 16:17:30 +0000 (13 17:17 +0100) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 17 Mar 2021 17:20:01 +0000 (17 10:20 -0700) | ||
| tree | 7dd8b0f475c7252adf47b032f550b02ab0dbf4e2 | treesnapshot (tar.gz zip) |
| parent | 94f6e3e283f2adfc518b39cfc39291f1c2832ad0 | commitdiff |
block-sha1: drop trailing semicolon from macro definition
23119ffb4e (block-sha1: put expanded macro parameters in parentheses,
2012-07-22) added a trailing semicolon to the definition of SHA_MIX
without explanation. It doesn't matter with the current code, but make
sure to avoid potential surprises by removing it again.
This allows the macro to be used almost like a function: Users can
combine it with operators of their choice, but still must not pass an
expression with side-effects as a parameter, as it would be evaluated
multiple times.
Signed-off-by: René Scharfe <l.s.r@web.de>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
23119ffb4e (block-sha1: put expanded macro parameters in parentheses,
2012-07-22) added a trailing semicolon to the definition of SHA_MIX
without explanation. It doesn't matter with the current code, but make
sure to avoid potential surprises by removing it again.
This allows the macro to be used almost like a function: Users can
combine it with operators of their choice, but still must not pass an
expression with side-effects as a parameter, as it would be evaluated
multiple times.
Signed-off-by: René Scharfe <l.s.r@web.de>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| block-sha1/sha1.c | diffblobblamehistory |