| commit | 351bca2d1f814e69740ac0b023bdfb7978b5c215 | |
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | |
| Wed, 7 Jul 2021 09:05:24 +0000 (7 11:05 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 7 Jul 2021 21:29:12 +0000 (7 14:29 -0700) | ||
| tree | 9165ada9878d5e111a428c5437ac0512c3b3eedb | treesnapshot (tar.gz zip) |
| parent | 670b81a890388c60b7032a4f5b879f2ece8c4558 | commitdiff |
imap-send.c: use less verbose strbuf_fread() idiom
When looking for things that hardcoded a non-zero "hint" parameter to
strbuf_fread() I discovered that since f2561fda364 (Add git-imap-send,
derived from isync 1.0.1., 2006-03-10) we've been passing a hardcoded
4096 in imap-send.c to read stdin.
Since we're not doing anything unusual here let's use a less verbose
pattern used in a lot of other places (the hint of "0" will default to
8192). We don't need to take a FILE * here either, so we can use "0"
instead of "stdin". While we're at it improve the error message if we
can't read the input to use error_errno().
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
When looking for things that hardcoded a non-zero "hint" parameter to
strbuf_fread() I discovered that since f2561fda364 (Add git-imap-send,
derived from isync 1.0.1., 2006-03-10) we've been passing a hardcoded
4096 in imap-send.c to read stdin.
Since we're not doing anything unusual here let's use a less verbose
pattern used in a lot of other places (the hint of "0" will default to
8192). We don't need to take a FILE * here either, so we can use "0"
instead of "stdin". While we're at it improve the error message if we
can't read the input to use error_errno().
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| imap-send.c | diffblobblamehistory |