| commit | 34ba05c2966f9e96b74ea984251e3bda802d6a7a | |
| author | Eric Sunshine <sunshine@sunshineco.com> | |
| Mon, 13 Dec 2021 06:30:57 +0000 (13 01:30 -0500) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 13 Dec 2021 22:15:29 +0000 (13 14:15 -0800) | ||
| tree | 4c50e731fb7f441242b6d6b5a4f8582889450d6f | treesnapshot (tar.gz zip) |
| parent | 22597af97d67660fb3f0dba538a1f02b1ba94243 | commitdiff |
chainlint.sed: stop throwing away here-doc tags
The purpose of chainlint is to highlight problems it finds in test code
by inserting annotations at the location of each problem. Arbitrarily
eliding bits of the code it is checking is not helpful, yet this is
exactly what chainlint.sed does by cavalierly and unnecessarily dropping
the here-doc operator and tag; i.e. `cat <<TAG` becomes simply `cat` in
the output. This behavior can make it more difficult for the test writer
to align the annotated output of chainlint.sed with the original test
code. Address this by retaining here-doc tags.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The purpose of chainlint is to highlight problems it finds in test code
by inserting annotations at the location of each problem. Arbitrarily
eliding bits of the code it is checking is not helpful, yet this is
exactly what chainlint.sed does by cavalierly and unnecessarily dropping
the here-doc operator and tag; i.e. `cat <<TAG` becomes simply `cat` in
the output. This behavior can make it more difficult for the test writer
to align the annotated output of chainlint.sed with the original test
code. Address this by retaining here-doc tags.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>