| commit | 19fb896f5b6f3e52370b43e4c9339bcbe4c0f2dd | |
| author | Alexander Gavrilov <angavrilov@gmail.com> | |
| Sun, 2 Nov 2008 17:11:13 +0000 (2 20:11 +0300) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Thu, 6 Nov 2008 17:26:06 +0000 (6 09:26 -0800) | ||
| tree | ffb92e83683b335365def294a1108929adda0d25 | treesnapshot (tar.gz zip) |
| parent | 6331adb9c4ec36c70dc3ecc6eb46b7dddb36952d | commitdiff |
Windows: Make OpenSSH properly detect tty detachment.
Apparently, CREATE_NO_WINDOW makes the OS tell the process
that it has a console, but without actually creating the
window. As a result, when git is started from GUI, ssh
tries to ask its questions on the invisible console.
This patch uses DETACHED_PROCESS instead, which clearly
means that the process should be left without a console.
The downside is that if the process manually calls
AllocConsole, the window will appear. A similar thing
might occur if it calls another console executable.
Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>
Acked-by: Johannes Sixt <johannes.sixt@telecom.at>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Apparently, CREATE_NO_WINDOW makes the OS tell the process
that it has a console, but without actually creating the
window. As a result, when git is started from GUI, ssh
tries to ask its questions on the invisible console.
This patch uses DETACHED_PROCESS instead, which clearly
means that the process should be left without a console.
The downside is that if the process manually calls
AllocConsole, the window will appear. A similar thing
might occur if it calls another console executable.
Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>
Acked-by: Johannes Sixt <johannes.sixt@telecom.at>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| compat/mingw.c | diffblobblamehistory |