From f82cd3c6104733e2ff3305c325a440731aa1d17c Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Thu, 3 Aug 2006 11:50:10 -0700 Subject: [PATCH] Fix "git diff blob1 blob2" showing the diff in reverse. This was introduced by mistake when revision.c::add_pending_object() was modified to use object-array instead of object-list. Signed-off-by: Junio C Hamano --- builtin-diff.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/builtin-diff.c b/builtin-diff.c index 48d2fd03b7..ec27542d48 100644 --- a/builtin-diff.c +++ b/builtin-diff.c @@ -125,9 +125,6 @@ static int builtin_diff_blobs(struct rev_info *revs, int argc, const char **argv, struct blobinfo *blob) { - /* Blobs: the arguments are reversed when setup_revisions() - * picked them up. - */ unsigned mode = canon_mode(S_IFREG | 0644); if (argc > 1) @@ -135,7 +132,7 @@ static int builtin_diff_blobs(struct rev_info *revs, stuff_change(&revs->diffopt, mode, mode, - blob[1].sha1, blob[0].sha1, + blob[0].sha1, blob[1].sha1, blob[0].name, blob[0].name); diffcore_std(&revs->diffopt); diff_flush(&revs->diffopt); -- 2.11.4.GIT