From 61ef5e9b56e1c16f6d3c142e2c63f6e2c720c64e Mon Sep 17 00:00:00 2001 From: Brandon Casey Date: Sun, 26 Sep 2010 22:18:01 -0500 Subject: [PATCH] git-send-email.perl: ensure $domain is defined before using it valid_fqdn() may attempt to operate on an undefined value if Net::Domain::domainname fails to determine the domain name. This causes perl to emit unpleasant warnings. So, add a check for whether $domain has been defined before using it. Signed-off-by: Brandon Casey Signed-off-by: Junio C Hamano --- git-send-email.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-send-email.perl b/git-send-email.perl index 6dab3bf6a7..e1f29a72a1 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -895,7 +895,7 @@ sub sanitize_address { sub valid_fqdn { my $domain = shift; - return !($^O eq 'darwin' && $domain =~ /\.local$/) && $domain =~ /\./; + return defined $domain && !($^O eq 'darwin' && $domain =~ /\.local$/) && $domain =~ /\./; } sub maildomain_net { -- 2.11.4.GIT