From 26e28fe7bbdf8b22ed096dfd76a9311e86ffb200 Mon Sep 17 00:00:00 2001 From: Jeff King Date: Wed, 30 Sep 2020 08:30:27 -0400 Subject: [PATCH] test-advise: check argument count with argc instead of argv We complain if "test-tool advise" is not given an argument, but we quietly ignore any additional arguments it receives. Let's instead check that we got the expected number. As a bonus, this silences -Wunused-parameter, which notes that we don't ever look at argc. While we're here, we can also fix the indentation in the conditional. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- t/helper/test-advise.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/helper/test-advise.c b/t/helper/test-advise.c index 38cdc2884e..a7043df1d3 100644 --- a/t/helper/test-advise.c +++ b/t/helper/test-advise.c @@ -5,8 +5,8 @@ int cmd__advise_if_enabled(int argc, const char **argv) { - if (!argv[1]) - die("usage: %s ", argv[0]); + if (argc != 2) + die("usage: %s ", argv[0]); setup_git_directory(); git_config(git_default_config, NULL); -- 2.11.4.GIT