unpack: replace xwrite() loop with write_in_full()
commitfa6c383309557b9d2942c47b75a895ca960ad9f5
authorJunio C Hamano <gitster@pobox.com>
Sat, 2 Mar 2024 19:03:46 +0000 (2 11:03 -0800)
committerJunio C Hamano <gitster@pobox.com>
Sat, 2 Mar 2024 19:12:16 +0000 (2 11:12 -0800)
tree534c6d89339dcf0228d7fdb90db9cd51591a5692
parentb387623c12f3f4a376e4d35a610fd3e55d7ea907
unpack: replace xwrite() loop with write_in_full()

We have two packfile stream consumers, index-pack and
unpack-objects, that allow excess payload after the packfile stream
data. Their code to relay excess data hasn't changed significantly
since their original implementation that appeared in 67e5a5ec
(git-unpack-objects: re-write to read from stdin, 2005-06-28) and
9bee2478 (mimic unpack-objects when --stdin is used with index-pack,
2006-10-25).

These code blocks contain hand-rolled loops using xwrite(), written
before our write_in_full() helper existed. This helper now provides
the same functionality.

Replace these loops with write_in_full() for shorter, clearer
code. Update related variables accordingly.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/index-pack.c
builtin/unpack-objects.c