builtin/receive-pack: fix incorrect pointer arithmetic
commitf2214dede950e506d7637744599ef27b149bbda1
authorbrian m. carlson <sandals@crustytoothpaste.net>
Sun, 26 Mar 2017 16:01:28 +0000 (26 16:01 +0000)
committerJunio C Hamano <gitster@pobox.com>
Tue, 28 Mar 2017 16:57:14 +0000 (28 09:57 -0700)
treeccddf6f0c43fab24fdab2568d82b28748c9b1dd1
parent6f5ef44e0d8933621fcd50127518557013002313
builtin/receive-pack: fix incorrect pointer arithmetic

If we had already processed the last newline in a push certificate, we
would end up subtracting NULL from the end-of-certificate pointer when
computing the length of the line.  This would have resulted in an
absurdly large length, and possibly a buffer overflow.  Instead,
subtract the beginning-of-certificate pointer from the
end-of-certificate pointer, which is what's expected.

Note that this situation should never occur, since not only do we
require the certificate to be newline terminated, but the signature will
only be read from the beginning of a line.  Nevertheless, it seems
prudent to correct it.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/receive-pack.c