Git.pm: add the "use warnings" pragma
commitf0e19cb7ced7b640d363b61d7ce17b83901777da
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Sun, 25 Feb 2018 19:46:27 +0000 (25 19:46 +0000)
committerJunio C Hamano <gitster@pobox.com>
Tue, 27 Feb 2018 22:52:46 +0000 (27 14:52 -0800)
treea7e71f605fd3723bdd07eea04bf791bc96577a03
parent872ba001f8caaeb496ad79c55fe587a5e31b54f2
Git.pm: add the "use warnings" pragma

Amend Git.pm to load the "warnings" pragma like the rest of the code
in perl/ in addition to the existing "strict" pragma. This is
considered the bare minimum best practice in Perl.

Ever since this code was introduced in b1edc53d06 ("Introduce
Git.pm (v4)", 2006-06-24) it's only been using "strict", not
"warnings".

This leaves contrib/buildsystems/Generators/{QMake,VCproj}.pm and
contrib/mw-to-git/Git/Mediawiki.pm without "use warnings". Amending
those would be a sensible follow-up change, but I don't have an easy
way to test those so I'm not changing them.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
perl/Git.pm