t/chainlint: add chainlint "loop" and "conditional" test cases
commitebcbbe060f5805bacafaf971fe9c0c0519b18f61
authorEric Sunshine <sunshine@sunshineco.com>
Wed, 11 Jul 2018 06:46:39 +0000 (11 02:46 -0400)
committerJunio C Hamano <gitster@pobox.com>
Tue, 17 Jul 2018 16:15:14 +0000 (17 09:15 -0700)
tree31dccce86ca77c2cf69c03a28f26e976080ce754
parentbb4efbc5df9d0c96392dd14fc3ab6164949a2f52
t/chainlint: add chainlint "loop" and "conditional" test cases

The --chain-lint option uses heuristics and knowledge of shell syntax to
detect broken &&-chains in subshells by pure textual inspection. The
heuristics handle a range of stylistic variations in existing tests
(evolved over the years), however, they are still best-guesses. As such,
it is possible for future changes to accidentally break assumptions upon
which the heuristics are based. Protect against this possibility by
adding tests which check the linter itself for correctness.

In addition to protecting against regressions, these tests help document
(for humans) expected behavior, which is important since the linter's
implementation language ('sed') does not necessarily lend itself to easy
comprehension.

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/chainlint/case.expect [new file with mode: 0644]
t/chainlint/case.test [new file with mode: 0644]
t/chainlint/exit-loop.expect [new file with mode: 0644]
t/chainlint/exit-loop.test [new file with mode: 0644]
t/chainlint/for-loop.expect [new file with mode: 0644]
t/chainlint/for-loop.test [new file with mode: 0644]
t/chainlint/if-then-else.expect [new file with mode: 0644]
t/chainlint/if-then-else.test [new file with mode: 0644]
t/chainlint/while-loop.expect [new file with mode: 0644]
t/chainlint/while-loop.test [new file with mode: 0644]