| commit | eab648d2b4c1ca6fbc28de454b51d7d00f5a3e60 | |
| author | Junio C Hamano <gitster@pobox.com> | |
| Tue, 16 May 2023 02:26:45 +0000 (15 19:26 -0700) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 16 May 2023 16:14:21 +0000 (16 09:14 -0700) | ||
| tree | 9874fd965c7d5368720fafc524e6d9f3b4f67029 | treesnapshot (tar.gz zip) |
| parent | c205923649568dee9c543d5b7f040d2c660a2272 | commitdiff |
t2021: do not negate test_path_is_dir
In this test, a path (some_dir) that is originally a directory is to
be removed and then to be replaced with a file of the same name.
The expectation is that the path becomes a file at the end.
However, "! test_path_is_dir some_dir" is used to catch a breakage
that leaves the path as a directory.
But as with all the "test_path_is..." helpers, this use of the
helper makes it loud when the expectation (i.e. it is a directory)
is met, and otherwise is silent when it is not---this does not help
debugging.
Be more explicit and state that we expect the path to become a file.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
In this test, a path (some_dir) that is originally a directory is to
be removed and then to be replaced with a file of the same name.
The expectation is that the path becomes a file at the end.
However, "! test_path_is_dir some_dir" is used to catch a breakage
that leaves the path as a directory.
But as with all the "test_path_is..." helpers, this use of the
helper makes it loud when the expectation (i.e. it is a directory)
is met, and otherwise is silent when it is not---this does not help
debugging.
Be more explicit and state that we expect the path to become a file.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| t/t2021-checkout-overwrite.sh | diffblobblamehistory |