| commit | e8c42cb9ce6a566aad797cc6c5bc1279d608d819 | |
| author | Jeff King <peff@peff.net> | |
| Thu, 6 Oct 2016 16:48:42 +0000 (6 12:48 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 10 Oct 2016 17:53:33 +0000 (10 10:53 -0700) | ||
| tree | e43133ea5a1cd25e181b3daf7cdbab1a82104cbb | treesnapshot (tar.gz zip) |
| parent | 3f7bd767ed6df4dbbc36c5ab881c0de668107001 | commitdiff |
files_read_raw_ref: prevent infinite retry loops in general
Limit the number of retries to 3. That should be adequate to
prevent any races, while preventing the possibility of
infinite loops if the logic fails to handle any other
possible error modes correctly.
After the fix in the previous commit, there's no known way
to trigger an infinite loop, but I did manually verify that
this fixes the test in that commit even when the code change
is not applied.
Signed-off-by: Jeff King <peff@peff.net>
Reviewed-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Limit the number of retries to 3. That should be adequate to
prevent any races, while preventing the possibility of
infinite loops if the logic fails to handle any other
possible error modes correctly.
After the fix in the previous commit, there's no known way
to trigger an infinite loop, but I did manually verify that
this fixes the test in that commit even when the code change
is not applied.
Signed-off-by: Jeff King <peff@peff.net>
Reviewed-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| refs/files-backend.c | diffblobblamehistory |