| commit | e885a84f1bc660adfc1dea5f6c25d0a92c7c9dbc | |
| author | Jeff King <peff@peff.net> | |
| Wed, 30 Sep 2020 12:28:18 +0000 (30 08:28 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 30 Sep 2020 19:53:47 +0000 (30 12:53 -0700) | ||
| tree | df5a532a5b78b284819f8a1f4eddadd7a66484f1 | treesnapshot (tar.gz zip) |
| parent | 185e86522678fed077d6cec02381bcf899bf24e5 | commitdiff |
drop unused argc parameters
Many functions take an argv/argc pair, but never actually look at argc.
This makes it useless at best (we use the NULL sentinel in argv to find
the end of the array), and misleading at worst (what happens if the argc
count does not match the argv NULL?).
In each of these instances, the argv NULL does match the argc count, so
there are no bugs here. But let's tighten the interfaces to make it
harder to get wrong (and to reduce some -Wunused-parameter complaints).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Many functions take an argv/argc pair, but never actually look at argc.
This makes it useless at best (we use the NULL sentinel in argv to find
the end of the array), and misleading at worst (what happens if the argc
count does not match the argv NULL?).
In each of these instances, the argv NULL does match the argc count, so
there are no bugs here. But let's tighten the interfaces to make it
harder to get wrong (and to reduce some -Wunused-parameter complaints).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>