add--interactive: quote commentChar regex
commitd85d7ecb80ebc93f7380b4196c303756ee051668
authorJeff King <peff@peff.net>
Wed, 21 Jun 2017 19:28:59 +0000 (21 15:28 -0400)
committerJunio C Hamano <gitster@pobox.com>
Wed, 21 Jun 2017 21:06:20 +0000 (21 14:06 -0700)
treee6d3a487d649072ded75b3141c9152664d7fdd3b
parentd5addcf522deb05d259ecbc0946584d977879565
add--interactive: quote commentChar regex

Since c9d961647 (i18n: add--interactive: mark
edit_hunk_manually message for translation, 2016-12-14),
when the user asks to edit a hunk manually, we respect
core.commentChar in generating the edit instructions.
However, when we then strip out comment lines, we use a
simple regex like:

  /^$commentChar/

If your chosen comment character is a regex metacharacter,
then that will behave in a confusing manner ("$", for
instance, would only eliminate blank lines, not actual
comment lines).

We can fix that by telling perl not to respect
metacharacters.

Reported-by: Christian Rösch <christian@croesch.de>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
git-add--interactive.perl
t/t3701-add-interactive.sh