receive-pack: relay connectivity errors to sideband
commitd415092ac4a7fb474dc9823a1cc08ae824267e35
authorJeff King <peff@peff.net>
Fri, 15 Jul 2016 10:36:14 +0000 (15 06:36 -0400)
committerJunio C Hamano <gitster@pobox.com>
Wed, 20 Jul 2016 19:11:10 +0000 (20 12:11 -0700)
tree80c748460c61d64c2372e60d8aff4d80b3e35c50
parentd06303bb9a6c3791ff67078b480a86cfd9b691ea
receive-pack: relay connectivity errors to sideband

If the connectivity check encounters a problem when
receiving a push, the error output goes to receive-pack's
stderr, whose destination depends on the protocol used
(ssh tends to send it to the user, though without a "remote"
prefix; http will generally eat it in the server's error
log).

The information should consistently go back to the user, as
there is a reasonable chance their client is buggy and
generating a bad pack.

We can do so by muxing it over the sideband as we do with
other sub-process stderr.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/receive-pack.c