builtin/verify-tag.c: ignore SIGPIPE in gpg-interface
commitd281b45d754477e79a8e0228c8f5ce4195079238
authorSantiago Torres <santiago@nyu.edu>
Tue, 5 Apr 2016 16:07:24 +0000 (5 12:07 -0400)
committerJunio C Hamano <gitster@pobox.com>
Wed, 6 Apr 2016 16:02:02 +0000 (6 09:02 -0700)
tree9b60290b5e62ccff80a7ca0bf51d4d40133996ba
parent90f7b16b3adc78d4bbabbd426fb69aa78c714f71
builtin/verify-tag.c: ignore SIGPIPE in gpg-interface

The verify_signed_buffer() function may trigger a SIGPIPE when the
GPG child process terminates early (due to a bad keyid, for example)
and Git tries to write to it afterwards.  Previously, ignoring
SIGPIPE was done in builtin/verify-tag.c to avoid this issue.

However, any other caller who wants to call verify_signed_buffer()
would have to do the same.

Use sigchain_push(SIGPIPE, SIG_IGN) in verify_signed_buffer(),
pretty much like in sign_buffer(), so that any caller is not
required to perform this task.

This will avoid possible mistakes by further developers using
verify_signed_buffer().

Signed-off-by: Santiago Torres <santiago@nyu.edu>
Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/verify-tag.c
gpg-interface.c