| commit | d24b21e9fcaa9ed4b7966275a8d82406f578577d | |
| author | Michael Haggerty <mhagger@alum.mit.edu> | |
| Sat, 18 Jun 2016 04:15:17 +0000 (18 06:15 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 20 Jun 2016 18:38:20 +0000 (20 11:38 -0700) | ||
| tree | b8f5e8f018519b6bf31dc4f0370d9ada1152559f | treesnapshot (tar.gz zip) |
| parent | 4c4de89573fa29b7f97e7a9a3d0674dbdb6f2a28 | commitdiff |
for_each_reflog(): don't abort for bad references
If there is a file under "$GIT_DIR/logs" with no corresponding
reference, the old code was emitting an error message, aborting the
reflog iteration, and returning -1. But
* None of the callers was checking the exit value
* The callers all want to find all legitimate reflogs (sometimes for the
purpose of determining object reachability!) and wouldn't benefit from
a truncated iteration anyway.
So instead, emit an error message and skip the "broken" reflog, but
continue with the iteration.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
If there is a file under "$GIT_DIR/logs" with no corresponding
reference, the old code was emitting an error message, aborting the
reflog iteration, and returning -1. But
* None of the callers was checking the exit value
* The callers all want to find all legitimate reflogs (sometimes for the
purpose of determining object reachability!) and wouldn't benefit from
a truncated iteration anyway.
So instead, emit an error message and skip the "broken" reflog, but
continue with the iteration.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| refs/files-backend.c | diffblobblamehistory |