| commit | ce93a4c6127abdf1ad9eacd537edd1c571a18e41 | |
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | |
| Thu, 1 Jul 2021 10:51:27 +0000 (1 12:51 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Thu, 1 Jul 2021 19:32:22 +0000 (1 12:32 -0700) | ||
| tree | f5393dbc3f3ce9cd98ba2aa5d7f015b1bd796a30 | treesnapshot (tar.gz zip) |
| parent | 5726a6b4012cd41701927a6637b9f2070e7760ee | commitdiff |
dir.[ch]: replace dir_init() with DIR_INIT
Remove the dir_init() function and replace it with a DIR_INIT
macro. In many cases in the codebase we need to initialize things with
a function for good reasons, e.g. needing to call another function on
initialization. The "dir_init()" function was not one such case, and
could trivially be replaced with a more idiomatic macro initialization
pattern.
The only place where we made use of its use of memset() was in
dir_clear() itself, which resets the contents of an an existing struct
pointer. Let's use the new "memcpy() a 'blank' struct on the stack"
idiom to do that reset.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Remove the dir_init() function and replace it with a DIR_INIT
macro. In many cases in the codebase we need to initialize things with
a function for good reasons, e.g. needing to call another function on
initialization. The "dir_init()" function was not one such case, and
could trivially be replaced with a more idiomatic macro initialization
pattern.
The only place where we made use of its use of memset() was in
dir_clear() itself, which resets the contents of an an existing struct
pointer. Let's use the new "memcpy() a 'blank' struct on the stack"
idiom to do that reset.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>