| commit | ccf659e87c8fdb4edb5d2653c53bc9062c8eee76 | |
| author | Jeff King <peff@peff.net> | |
| Mon, 5 Nov 2018 06:39:20 +0000 (5 01:39 -0500) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 6 Nov 2018 03:55:35 +0000 (6 12:55 +0900) | ||
| tree | ca873a311dbfb009358875c15401affd4bbf0ec0 | treesnapshot (tar.gz zip) |
| parent | fce56648056acf476aa810a02c6eb33cbcabb6c9 | commitdiff |
ls-files: mark exclude options as NONEG
Running "git ls-files --no-exclude" will currently segfault, as its
option callback does not handle the "unset" parameter.
In theory this could be used to clear the exclude list, but it is not
clear how that would interact with the other exclude options, nor is the
current code capable of clearing the list. Let's just disable the broken
option.
Note that --no-exclude-from will similarly segfault, but
--no-exclude-standard will not. It just silently does the wrong thing
(pretending as if --exclude-standard was specified).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Running "git ls-files --no-exclude" will currently segfault, as its
option callback does not handle the "unset" parameter.
In theory this could be used to clear the exclude list, but it is not
clear how that would interact with the other exclude options, nor is the
current code capable of clearing the list. Let's just disable the broken
option.
Note that --no-exclude-from will similarly segfault, but
--no-exclude-standard will not. It just silently does the wrong thing
(pretending as if --exclude-standard was specified).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/ls-files.c | diffblobblamehistory |