| commit | bd9150b7e5f34d7148b02ca2eed96270c7744049 | |
| author | Junio C Hamano <gitster@pobox.com> | |
| Sun, 15 Feb 2015 21:47:36 +0000 (15 13:47 -0800) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Sun, 15 Feb 2015 23:38:16 +0000 (15 15:38 -0800) | ||
| tree | e9b3870a6d10befcfe4b106bf6c349703fe2f38a | treesnapshot (tar.gz zip) |
| parent | 459b8d22e544b3876a2270ee7290c289a39ebbb2 | commitdiff |
t/diff-lib: check exact object names in compare_diff_raw
The "sanitize" helper wanted to strip the similarity and
dissimilarity scores when making comparison, but it was
stripping away the object names as well.
While we do not want to require the exact object names the tests
expect to be maintained, as it would be seen as an extra burden,
this would have prevented us catching a silly bug such as showing
non 0{40} object name on the preimage side of an addition or on the
postimage side of a deletion, because all [0-9a-f]{40} strings were
considered equally OK.
In the longer term, when a test only wants to see the status of the
change without having to worry about object names, it should be
rewritten not to inspect the raw format.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The "sanitize" helper wanted to strip the similarity and
dissimilarity scores when making comparison, but it was
stripping away the object names as well.
While we do not want to require the exact object names the tests
expect to be maintained, as it would be seen as an extra burden,
this would have prevented us catching a silly bug such as showing
non 0{40} object name on the preimage side of an addition or on the
postimage side of a deletion, because all [0-9a-f]{40} strings were
considered equally OK.
In the longer term, when a test only wants to see the status of the
change without having to worry about object names, it should be
rewritten not to inspect the raw format.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| t/diff-lib.sh | diffblobblamehistory |