Convert lookup_commit* to struct object_id
commitbc83266abe36905cade4719cbaeb8a62d0a382da
authorbrian m. carlson <sandals@crustytoothpaste.net>
Sat, 6 May 2017 22:10:10 +0000 (6 22:10 +0000)
committerJunio C Hamano <gitster@pobox.com>
Mon, 8 May 2017 06:12:57 +0000 (8 15:12 +0900)
tree3ecacd438394beb967e46dc2cfb0eb3808a60008
parent1e43ed986775d8e8ecaef4dac8b98dcbae6298c1
Convert lookup_commit* to struct object_id

Convert lookup_commit, lookup_commit_or_die,
lookup_commit_reference, and lookup_commit_reference_gently to take
struct object_id arguments.

Introduce a temporary in parse_object buffer in order to convert this
function.  This is required since in order to convert parse_object and
parse_object_buffer, lookup_commit_reference_gently and
lookup_commit_or_die would need to be converted.  Not introducing a
temporary would therefore require that lookup_commit_or_die take a
struct object_id *, but lookup_commit would take unsigned char *,
leaving a confusing and hard-to-use interface.

parse_object_buffer will lose this temporary in a later patch.

This commit was created with manual changes to commit.c, commit.h, and
object.c, plus the following semantic patch:

@@
expression E1, E2;
@@
- lookup_commit_reference_gently(E1.hash, E2)
+ lookup_commit_reference_gently(&E1, E2)

@@
expression E1, E2;
@@
- lookup_commit_reference_gently(E1->hash, E2)
+ lookup_commit_reference_gently(E1, E2)

@@
expression E1;
@@
- lookup_commit_reference(E1.hash)
+ lookup_commit_reference(&E1)

@@
expression E1;
@@
- lookup_commit_reference(E1->hash)
+ lookup_commit_reference(E1)

@@
expression E1;
@@
- lookup_commit(E1.hash)
+ lookup_commit(&E1)

@@
expression E1;
@@
- lookup_commit(E1->hash)
+ lookup_commit(E1)

@@
expression E1, E2;
@@
- lookup_commit_or_die(E1.hash, E2)
+ lookup_commit_or_die(&E1, E2)

@@
expression E1, E2;
@@
- lookup_commit_or_die(E1->hash, E2)
+ lookup_commit_or_die(E1, E2)

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
50 files changed:
archive.c
bisect.c
branch.c
builtin/am.c
builtin/blame.c
builtin/branch.c
builtin/checkout.c
builtin/clone.c
builtin/commit-tree.c
builtin/commit.c
builtin/describe.c
builtin/diff-tree.c
builtin/fast-export.c
builtin/fetch.c
builtin/fmt-merge-msg.c
builtin/log.c
builtin/merge-base.c
builtin/merge.c
builtin/notes.c
builtin/pull.c
builtin/reflog.c
builtin/replace.c
builtin/reset.c
builtin/rev-parse.c
builtin/show-branch.c
builtin/tag.c
builtin/verify-commit.c
bundle.c
commit.c
commit.h
fast-import.c
fetch-pack.c
http-push.c
log-tree.c
notes-cache.c
notes-merge.c
notes-utils.c
object.c
parse-options-cb.c
ref-filter.c
remote.c
revision.c
sequencer.c
sha1_name.c
shallow.c
submodule.c
tag.c
tree.c
walker.c
wt-status.c