| commit | b5f4dcb598bb369c960f715fcd5c9ccf4112e026 | |
| author | Jeff King <peff@peff.net> | |
| Tue, 5 Sep 2017 12:14:50 +0000 (5 08:14 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 6 Sep 2017 08:19:53 +0000 (6 17:19 +0900) | ||
| tree | 4a1c222f72fe2eb8e5ed3273a928470206975075 | treesnapshot (tar.gz zip) |
| parent | 2933ebbac1967a677eaed1945068941bc3ff7751 | commitdiff |
tempfile: factor out deactivation
When we deactivate a tempfile, we also have to clean up the
"filename" strbuf. Let's pull this out into its own function
to keep the logic in one place (which will become more
important when a future patch makes it more complicated).
Note that we can use the same function when deactivating an
object that _isn't_ actually active yet (like when we hit an
error creating a tempfile). These callsites don't currently
reset the "active" flag to 0, but it's OK to do so (it's
just a noop for these cases).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
When we deactivate a tempfile, we also have to clean up the
"filename" strbuf. Let's pull this out into its own function
to keep the logic in one place (which will become more
important when a future patch makes it more complicated).
Note that we can use the same function when deactivating an
object that _isn't_ actually active yet (like when we hit an
error creating a tempfile). These callsites don't currently
reset the "active" flag to 0, but it's OK to do so (it's
just a noop for these cases).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| tempfile.c | diffblobblamehistory |