| commit | aef591a0f91a80d2b39c5344653861967d70d720 | |
| author | Jeff King <peff@peff.net> | |
| Fri, 20 Mar 2015 10:12:55 +0000 (20 06:12 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 20 Mar 2015 17:20:17 +0000 (20 10:20 -0700) | ||
| tree | 470f0a16d12391b58b352f2f338f378aed06835e | treesnapshot (tar.gz zip) |
| parent | 27a6625b13d7475d28f425adb2b7be221cf3c8e0 | commitdiff |
t7201: fix &&-chain breakage
One of these breakages is in setup, but one is more severe
and may miss a real test failure. These are pulled out from
the rest, though, because we also clean up a few other
anachronisms. The most interesting is the use of this
here-doc construct:
(cat >... <<EOF
...
EOF
) &&
It looks like an attempt to make the &&-chaining more
natural by letting it come at the end of the here-doc. But
the extra sub-shell is so non-idiomatic (plus the lack of
"<<-") that it ends up confusing.
Since these are just using a single line, we can accomplish
the same thing with a single printf (which also makes the
use of tab more obvious than the verbatim whitespace).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
One of these breakages is in setup, but one is more severe
and may miss a real test failure. These are pulled out from
the rest, though, because we also clean up a few other
anachronisms. The most interesting is the use of this
here-doc construct:
(cat >... <<EOF
...
EOF
) &&
It looks like an attempt to make the &&-chaining more
natural by letting it come at the end of the here-doc. But
the extra sub-shell is so non-idiomatic (plus the lack of
"<<-") that it ends up confusing.
Since these are just using a single line, we can accomplish
the same thing with a single printf (which also makes the
use of tab more obvious than the verbatim whitespace).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| t/t7201-co.sh | diffblobblamehistory |