run_external_diff: use an argv_array for the environment
commitae049c955c8858899467f6c5c0259c48a5294385
authorJeff King <peff@peff.net>
Sat, 19 Apr 2014 19:17:25 +0000 (19 15:17 -0400)
committerJunio C Hamano <gitster@pobox.com>
Mon, 21 Apr 2014 17:30:33 +0000 (21 10:30 -0700)
tree37ff06375ab15e51dd7b283ee7f18363018a2670
parent82fbf269b9994d172719b2d456db5ef8453b323d
run_external_diff: use an argv_array for the environment

We currently use static buffers and a static array for
formatting the environment passed to the external diff.
There's nothing wrong in the code, but it is much easier to
verify that it is correct if we use a dynamic argv_array.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff.c