gc: perform incremental repack when implictly enabled
commita897ab7ed143b2790f05785a3b1916f8a71c7a8c
authorGlen Choo <chooglen@google.com>
Fri, 15 Oct 2021 20:16:31 +0000 (15 13:16 -0700)
committerJunio C Hamano <gitster@pobox.com>
Fri, 15 Oct 2021 21:30:10 +0000 (15 14:30 -0700)
treefac7b1d1a3bbd0faacb204e09f360b11c96d1709
parentdc5570872f684f7c838fe7571225d279243b8700
gc: perform incremental repack when implictly enabled

builtin/gc.c has two ways of checking if multi-pack-index is enabled:
- git_config_get_bool() in incremental_repack_auto_condition()
- the_repository->settings.core_multi_pack_index in
  maintenance_task_incremental_repack()

The two implementations have existed since the incremental-repack task
was introduced in e841a79a13 (maintenance: add incremental-repack auto
condition, 2020-09-25). These two values can diverge because
prepare_repo_settings() enables the feature in the_repository->settings
by default.

In the case where core.multiPackIndex is not set in the config, the auto
condition would fail, causing the incremental-repack task to not be
run. Because we always want to consider the default values, we should
always use the_repository->settings.

Standardize on using the_repository->settings.core_multi_pack_index to
check if multi-pack-index is enabled.

Signed-off-by: Glen Choo <chooglen@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/gc.c
t/t7900-maintenance.sh