treewide: remove unnecessary includes of cache.h
commita64acf7298e87740a596123d2b39fefe623fd46f
authorElijah Newren <newren@gmail.com>
Tue, 21 Mar 2023 06:26:02 +0000 (21 06:26 +0000)
committerJunio C Hamano <gitster@pobox.com>
Tue, 21 Mar 2023 17:56:53 +0000 (21 10:56 -0700)
tree7ed6bda75bba4ba467d90fd741100ba5202674fc
parentd5ebb50dcb2bae27cf9f233088f7258f21e72be7
treewide: remove unnecessary includes of cache.h

The last several commits were geared at replacing the include of cache.h
in strbuf.c with an include of git-compat-util.h.  Unfortunately, I had
to drop a patch moving some functions from cache.h to object-name.h, due
to excessive conflicts with other in-flight topics.

However, even without that patch, the series of patches so far allows us
to modify a number of C files to replace an include of cache.h with
git-compat-util.h.  Do that to reduce our dependencies.

(If we could have kept our object-name.h patch in this series, it would
have also let us reduce the includes in checkout.c and fmt-merge-msg.c
in addition to strbuf.c).

Just to ensure that nothing else was bringing in cache.h, all of the
affected files have been checked to ensure that
    gcc -E -I. $SOURCE_FILE | grep '"cache.h"'
found no hits and that
    make DEVELOPER=1 ${OBJECT_FILE_FOR_SOURCE_FILE}
successfully compiles without warnings.

Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
12 files changed:
compat/terminal.c
gpg-interface.c
lockfile.c
parse-options.c
t/helper/test-delta.c
t/helper/test-trace2.c
tempfile.c
trace2/tr2_cfg.c
trace2/tr2_cmd_name.c
trace2/tr2_dst.c
trace2/tr2_sid.c
usage.c