| commit | a070221eed679f626fc1cc0e7ea07a1a12ac4626 | |
| author | Jonathan Nieder <jrnieder@gmail.com> | |
| Sat, 24 Aug 2013 20:13:32 +0000 (24 13:13 -0700) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Sun, 25 Aug 2013 06:58:43 +0000 (24 23:58 -0700) | ||
| tree | 036867f9c626507a5f38b7e7c0bc3ab5bc3ddbe9 | treesnapshot (tar.gz zip) |
| parent | 0bb0c15533c52bfb6f7a5174265869b808faf7ee | commitdiff |
add -i test: use skip_all instead of repeated PERL prerequisite
It is too easy to forget to add the PERL prerequisite for new
"add -i" tests, especially given that many people do not test with
NO_PERL so the missing prereq is not always noticed quickly.
The test had used the skip_all mechanism since 1b19ccd2 (2009-04-03)
but switched to explicit PERL prereqs in f0459319 (2010-10-13) in hope
of helping people see how many tests were skipped, perhaps to motivate
them to tweak their platform or tests to improve test coverage. That
didn't pan out much in practice, so let's move back to the simpler
skip_all method.
Reported-by: Kacper Kornet <draenog@pld-linux.org>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
It is too easy to forget to add the PERL prerequisite for new
"add -i" tests, especially given that many people do not test with
NO_PERL so the missing prereq is not always noticed quickly.
The test had used the skip_all mechanism since 1b19ccd2 (2009-04-03)
but switched to explicit PERL prereqs in f0459319 (2010-10-13) in hope
of helping people see how many tests were skipped, perhaps to motivate
them to tweak their platform or tests to improve test coverage. That
didn't pan out much in practice, so let's move back to the simpler
skip_all method.
Reported-by: Kacper Kornet <draenog@pld-linux.org>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| t/t3701-add-interactive.sh | diffblobblamehistory |