| commit | 9ae9ca1f95ccd3b4c1d62d856eb8b48fdff7c2d5 | |
| author | Eric Sunshine <sunshine@sunshineco.com> | |
| Fri, 9 Aug 2013 21:39:54 +0000 (9 17:39 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 13 Aug 2013 16:08:58 +0000 (13 09:08 -0700) | ||
| tree | 139fda2f4b2dd14e14bef1c01b67343eaaad54d0 | treesnapshot (tar.gz zip) |
| parent | 5ce922a014f78684a96c3d03a51decf0d21fa58d | commitdiff |
contacts: validate hunk length earlier
Rather than calling get_blame() with a zero-length hunk only to have it
rejected immediately, perform hunk-length validation earlier in order to
avoid calling get_blame() unnecessarily.
This is a preparatory step to simplify later patches which reduce the
number of git-blame invocations by collecting together all lines to
blame within a single file at a particular revision. By validating the
blame range early, the subsequent patch can more easily avoid adding
empty ranges at collection time.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Rather than calling get_blame() with a zero-length hunk only to have it
rejected immediately, perform hunk-length validation earlier in order to
avoid calling get_blame() unnecessarily.
This is a preparatory step to simplify later patches which reduce the
number of git-blame invocations by collecting together all lines to
blame within a single file at a particular revision. By validating the
blame range early, the subsequent patch can more easily avoid adding
empty ranges at collection time.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| contrib/contacts/git-contacts | diffblobblamehistory |