| commit | 903fc7da44b091a87c4bc00a892930786c71a709 | |
| author | Jeff King <peff@peff.net> | |
| Tue, 28 Mar 2017 19:46:44 +0000 (28 15:46 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Thu, 30 Mar 2017 21:59:50 +0000 (30 14:59 -0700) | ||
| tree | cb93269a3d5c51e35ae92ec046f91c7e9d672ce7 | treesnapshot (tar.gz zip) |
| parent | cddac45219b70f121d30468811a9fbee78fa24f2 | commitdiff |
name-rev: replace static buffer with strbuf
When name-rev needs to format an actual name, we do so into
a fixed-size buffer. That includes the actual ref tip, as
well as any traversal information. Since refs can exceed
1024 bytes, this means you can get a bogus result. E.g.,
doing:
git tag $(perl -e 'print join("/", 1..1024)')
git describe --contains HEAD^
results in ".../282/283", when it should be
".../1023/1024~1".
We can solve this by using a heap buffer. We'll use a
strbuf, which lets us write into the same buffer from our
loop without having to reallocate.
Signed-off-by: Jeff King <peff@peff.net>
When name-rev needs to format an actual name, we do so into
a fixed-size buffer. That includes the actual ref tip, as
well as any traversal information. Since refs can exceed
1024 bytes, this means you can get a bogus result. E.g.,
doing:
git tag $(perl -e 'print join("/", 1..1024)')
git describe --contains HEAD^
results in ".../282/283", when it should be
".../1023/1024~1".
We can solve this by using a heap buffer. We'll use a
strbuf, which lets us write into the same buffer from our
loop without having to reallocate.
Signed-off-by: Jeff King <peff@peff.net>
| builtin/name-rev.c | diffblobblamehistory |